fix: Prune messages form not resetting properly#35962
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: d14cf19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
apps/meteor/client/views/room/contextualBar/PruneMessages/PruneMessages.tsx
Show resolved
Hide resolved
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35962 +/- ##
===========================================
+ Coverage 64.70% 64.72% +0.01%
===========================================
Files 3244 3247 +3
Lines 95356 95433 +77
Branches 17884 17909 +25
===========================================
+ Hits 61704 61770 +66
- Misses 30761 30765 +4
- Partials 2891 2898 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aleksandernsilva
left a comment
aleksandernsilva
left a comment
There was a problem hiding this comment.
Good fix, Yash. If it's not yet the case, I believe it would be a good idea to add tests to cover this feature.
Also, could you add a changeset and steps to reproduce to the PR?
|
@aleksandernsilva I'm writing tests for this 👍 |
cardoso
left a comment
cardoso
left a comment
There was a problem hiding this comment.
Looks good to me, I did some QA and added the tests @aleksandernsilva asked for.
cardoso
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Co-authored-by: Matheus Cardoso <5606812+cardoso@users.noreply.github.com>
3 participants
Proposed changes (including videos or screenshots)
Issue(s)
CORE-1146
Steps to test or reproduce
Further comments
Description
This pull request addresses an issue in the Rocket.Chat repository where the Prune Messages form was not resetting properly. The changes involve refactoring the checkbox handling within the
PruneMessages.tsxfile. Specifically, the form has been updated to use theControllercomponent fromreact-hook-forminstead of theregisterAPI. This change improves the integration with controlledCheckBoxcomponents and centralizes the form state management through thecontrolobject. The update aims to ensure that the form resets correctly and functions as expected.